Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roomba bin state checking #29030

merged 3 commits into from Nov 26, 2019


Copy link

freekode commented Nov 24, 2019


Fixed detection is bin full. Refactored part responsible for bin.
Now just grab info from roomba and set in state only available values.
There is no need to check is roomba has capabilities to check is bin is full

Related issue (if applicable): fixes #17382


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 24, 2019

Hey there @pschmitt, mind taking a look at this pull request as its been labeled with a integration (roomba) you are listed as a codeowner for? Thanks!

@freekode freekode closed this Nov 26, 2019
@freekode freekode reopened this Nov 26, 2019

This comment has been minimized.

Copy link
Contributor Author

freekode commented Nov 26, 2019

Why my PR not in review?

@MartinHjelmare MartinHjelmare changed the title Fixed bin full detection Fix roomba bin full detection Nov 26, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 26, 2019
@freekode freekode changed the title Fix roomba bin full detection Updated roomba bin state checking Nov 26, 2019
@MartinHjelmare MartinHjelmare changed the title Updated roomba bin state checking Update roomba bin state checking Nov 26, 2019
Copy link

MartinHjelmare left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@MartinHjelmare MartinHjelmare merged commit 4ea4733 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.90 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1495df3...13d7545
codecov/project 94.49% (target 90%)
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@freekode freekode deleted the freekode:fix-roomba branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.