Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL configuration #29038

Merged

Conversation

@USA-RedDragon
Copy link
Contributor

USA-RedDragon commented Nov 25, 2019

Description:

Allow the OpenGarage integration to configure the transport layer it uses to communicate (HTTP or HTTPS). See issue #29037

Related issue (if applicable): fixes #29037

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11283

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
cover:
  platform: opengarage
  covers:
    garage:
      ssl: true
      verify_ssl: false
      host: garage.example.com
      port: 443
      device_key: opendoor
      name: Right Garage Door

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 25, 2019

Hi @USA-RedDragon,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
@USA-RedDragon USA-RedDragon mentioned this pull request Nov 25, 2019
0 of 2 tasks complete
USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
@USA-RedDragon USA-RedDragon mentioned this pull request Nov 25, 2019
2 of 2 tasks complete
@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 25, 2019
@USA-RedDragon USA-RedDragon force-pushed the USA-RedDragon:upstream-opengarage-add-protocol branch from 255cd17 to 4c08d18 Nov 25, 2019
USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
@USA-RedDragon USA-RedDragon changed the title OpenGarage: Add protocol configuration (#29037) OpenGarage: Add SSL configuration (#29037) Nov 25, 2019
@fabaff fabaff changed the title OpenGarage: Add SSL configuration (#29037) Add SSL configuration Nov 25, 2019
USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
USA-RedDragon added a commit to USA-RedDragon/home-assistant.io that referenced this pull request Nov 25, 2019
@USA-RedDragon USA-RedDragon requested a review from pvizeli Nov 25, 2019
@balloob balloob merged commit d5db553 into home-assistant:dev Nov 25, 2019
11 checks passed
11 checks passed
CI #20191125.57 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 48c289f...066bcff
Details
codecov/project 94.47% (target 90%)
Details
balloob added a commit to home-assistant/home-assistant.io that referenced this pull request Nov 25, 2019
* OpenGarage: Add `protocol` documentation

This is the documentation companion of home-assistant/home-assistant#29038

* OpenGarage: Replace protocol with ssl

Documentation resolution of home-assistant/home-assistant#29038 (comment)

* OpenGarage: Add documentation for verify_ssl

Documentation companion of home-assistant/home-assistant@066bcff
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.