Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move eddystone_temperature imports at top-level #29052

Merged

Conversation

@Quentame
Copy link
Contributor

Quentame commented Nov 25, 2019

Breaking Change:

None

Description:

Related issue: partially fix #27284 + isort

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@Quentame Quentame force-pushed the Quentame:eddystone_temperature/move-imports branch from 3b5c5be to 495fcb4 Nov 25, 2019
Quentame added 2 commits Nov 25, 2019
@Quentame Quentame force-pushed the Quentame:eddystone_temperature/move-imports branch from 495fcb4 to ab88769 Nov 25, 2019
@fabaff
fabaff approved these changes Nov 25, 2019
@fabaff fabaff merged commit f971e16 into home-assistant:dev Nov 25, 2019
11 checks passed
11 checks passed
CI #20191125.100 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3dd5222...ab88769
Details
codecov/project 94.48% (target 90%)
Details
@Quentame Quentame deleted the Quentame:eddystone_temperature/move-imports branch Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.