Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported_features to Alarm Control Panel to limit device_actions #29065

Merged
merged 8 commits into from Nov 25, 2019

Conversation

@SukramJ
Copy link
Contributor

SukramJ commented Nov 25, 2019

Description:

This PR adds supported_features to Alarm Control Panel to limit device_actions

If this PR is too big let me know how to slice it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@SukramJ SukramJ requested review from bachya, Jc2k and home-assistant/core as code owners Nov 25, 2019
SukramJ added 5 commits Nov 25, 2019
@SukramJ SukramJ requested a review from balloob Nov 25, 2019
return SUPPORT_ALARM_ARM_HOME | SUPPORT_ALARM_ARM_AWAY

@property
def unique_id(self):

This comment has been minimized.

Copy link
@bachya

bachya Nov 25, 2019

Contributor

This isn't necessary – it's already provided by the SimpliSafeEntity base class.

Copy link
Member

balloob left a comment

ok to merge when unique ID dropped from simplisafe.

@balloob balloob merged commit 1fde0d1 into home-assistant:dev Nov 25, 2019
1 check passed
1 check passed
cla-bot Everyone involved has signed the CLA
@balloob balloob mentioned this pull request Nov 25, 2019
5 of 9 tasks complete
@SukramJ SukramJ deleted the SukramJ:ACP_supported_features branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.