Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move velux imports at top-level #29085

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

@Quentame
Copy link
Contributor

Quentame commented Nov 25, 2019

Breaking Change:

None

Description:

Related issue: partially f!x #27284 + isort

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 25, 2019

Hey there @Julius2342, mind taking a look at this pull request as its been labeled with a integration (velux) you are listed as a codeowner for? Thanks!

@balloob balloob merged commit 29e2201 into home-assistant:dev Nov 25, 2019
12 checks passed
12 checks passed
CI #20191125.105 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3dd5222...e674042
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
@Quentame Quentame deleted the Quentame:velux/move-imports branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.