Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move icloud imports at top-level #29089

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@Quentame
Copy link
Contributor

Quentame commented Nov 26, 2019

Breaking Change:

None

Description:

Related issue: partially f!x #27284 + isort

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Nov 26, 2019

This might interfere with the open iCloud PR #28968

Oh, that's also you

@Quentame

This comment has been minimized.

Copy link
Contributor Author

Quentame commented Nov 26, 2019

Yep, no worries about the rebase 😉

@Quentame Quentame force-pushed the Quentame:icloud/move-imports branch from 0612e7d to 31bc4b0 Nov 26, 2019
@MartinHjelmare MartinHjelmare added this to Reviewer approved in Dev Nov 26, 2019
@balloob balloob merged commit 78d5184 into home-assistant:dev Nov 26, 2019
6 of 9 checks passed
6 of 9 checks passed
CI #20191126.35 failed
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@Quentame Quentame deleted the Quentame:icloud/move-imports branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.