Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domain for monoprice from 'media_player' to 'monoprice' #29099

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 26, 2019

Breaking Change:

This change breaks existing service call references to the media_player.snapshot and media_player.restore services by changing the service calls to be monoprice.snapshot and monoprice.restore respectively. My understanding is that because this is not a service provided by the base media_player component, it should live in the domain of the monoprice component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for media_player.snapshot and media_player.restore. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11297

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
… domain
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 26, 2019

Hey there @etsinko, mind taking a look at this pull request as its been labeled with a integration (monoprice) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@balloob balloob merged commit 499838d into home-assistant:dev Nov 26, 2019
7 of 10 checks passed
7 of 10 checks passed
CI #20191126.51 failed
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@raman325 raman325 deleted the raman325:monoprice_service_update branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.