Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domain for blackbird from 'media_player' to 'blackbird' #29112

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 26, 2019

Breaking Change:

This change breaks existing service call references to the media_player.blackbird_set_all_zones services by changing the service calls to be blackbird.set_all_zones. My understanding is that because this is not a service provided by the base media_player component, it should live in the domain of the blackbird component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for media_player.blackbird_set_all_zones. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11299

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
raman325 added 2 commits Nov 26, 2019
…omain
…fferent branch
Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@balloob balloob merged commit 9e01591 into home-assistant:dev Nov 26, 2019
12 checks passed
12 checks passed
CI #20191126.80 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.49%)
Details
codecov/project 94.49% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@raman325 raman325 deleted the raman325:blackbird_service_update branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.