Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the alarm_control_panel CODEOWNER #29114

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@colinodell
Copy link
Contributor

colinodell commented Nov 26, 2019

Although I originally contributed the manual alarm with MQTT control, I no longer use it myself and haven't been following the internal development of HA, so I'm no longer a good person to review any further changes to this component. I would therefore like to relinquish my CODEOWNER status over this component.

@project-bot project-bot bot added this to Needs review in Dev Nov 26, 2019
Dev automation moved this from Needs review to Review in progress Nov 26, 2019
Copy link
Member

MartinHjelmare left a comment

Please update the manifest file and then run script/gen_requirements_all.py and commit the changes. That will let the build pass.

CODEOWNERS Show resolved Hide resolved
Although I originally contributed this component, I no longer use it myself and haven't been following the internal development of HA, so I'm no longer a good person to review any further changes to this component.  I would therefore like to relinquish my CODEOWNER status over this component.
@colinodell colinodell force-pushed the colinodell:patch-1 branch from c4a4202 to c52d809 Nov 26, 2019
Copy link
Member

MartinHjelmare left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Nov 26, 2019
@MartinHjelmare MartinHjelmare merged commit 0849d42 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.93 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing fe626f5...c52d809
Details
codecov/project 94.5% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.