Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Alexa interface selection for binary sensors #29120

Merged
merged 3 commits into from Dec 3, 2019

Conversation

@abmantis
Copy link
Contributor

abmantis commented Nov 26, 2019

Description:

This allows the sensor to work correctly as a contact or motion sensor in alexa, if the user overrides its display category as such.
Without this, if the user sets a binary sensor display category to CONTACT_SENSOR, for example, Alexa will show an error for that device, unless the binary sensor HA display_class is door.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
This allows the sensor to work correctly as a contact or motion sensor
in alexa, if the user overrides its display category as such.
@project-bot project-bot bot added this to Needs review in Dev Nov 26, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 26, 2019

Hey there @home-assistant/cloud, @ochlocracy, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Nov 27, 2019

In what scenario does the entity not have the right device class? That seems like a bug in the integration.

@abmantis

This comment has been minimized.

Copy link
Contributor Author

abmantis commented Nov 27, 2019

@balloob Lets say you have a leak sensor, that has the correct device class. If I want to be able to use it in Alexa I would need to force it into the CONTACT_SENSOR or MOTION_SENSOR display_category.

abmantis added 2 commits Dec 1, 2019
…into alexa_binary_sensors
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 2, 2019

I see. that's fine for now. Ok to merge when docs PR linked.

@balloob balloob added the docs-missing label Dec 2, 2019
@balloob
balloob approved these changes Dec 2, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 2, 2019
@abmantis

This comment has been minimized.

Copy link
Contributor Author

abmantis commented Dec 2, 2019

@balloob what docs? The display categories were already documented previously, they were just not working properly (the sensor would appear with the correct type in alexa, but with an error).

@balloob balloob removed the docs-missing label Dec 3, 2019
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 3, 2019

ok

@balloob balloob merged commit 9811d63 into home-assistant:dev Dec 3, 2019
11 of 12 checks passed
11 of 12 checks passed
docs-missing Please open a documentation PR.
CI #20191201.65 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.