Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domain for alarmdecoder from 'alarm_control_panel' to 'alarmdecoder' #29127

Merged
merged 5 commits into from Nov 28, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the alarm_control_panel.alarmdecoder_alarm_toggle_chime services by changing the service calls to be alarmdecoder.alarm_toggle_chime. My understanding is that because this is not a service provided by the base alarm_control_panel component, it should live in the domain of the alarmdecoder component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for alarmdecoder.alarm_toggle_chime. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11304

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
raman325 added 3 commits Nov 27, 2019
Copy link
Member

Santobert left a comment

Looks good to me. Please solve the merge conflicts

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
raman325 added 2 commits Nov 27, 2019
@balloob balloob merged commit f1a4e21 into home-assistant:dev Nov 28, 2019
11 checks passed
11 checks passed
CI #20191127.103 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing fa1622f...6b40b7f
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 28, 2019
@raman325 raman325 deleted the raman325:alarmdecoder_service_update branch Nov 28, 2019
@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.