Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domain for todoist from 'calendar' to 'todoist' #29131

Merged
merged 4 commits into from Nov 27, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the calendar.todoist_new_task services by changing the service calls to be todoist.new_task. My understanding is that because this is not a service provided by the base calendar component, it should live in the domain of the todoist component instead. If that's the case, then it also makes sense to update the service name.

Description:

Update the domain and service name for todoist.new_task. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11306

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @boralyl, mind taking a look at this pull request as its been labeled with a integration (todoist) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
raman325 added 3 commits Nov 27, 2019
Copy link
Contributor

boralyl left a comment

This makes sense to me, I didn't realize the service was also defined under the calendar component. Thanks for taking the time to make these updates!

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@pvizeli pvizeli merged commit 1681d36 into home-assistant:dev Nov 27, 2019
12 checks passed
12 checks passed
CI #20191127.21 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.5% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@raman325 raman325 deleted the raman325:todoist_service_update branch Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.