Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domains for xiaomi_miio from base domains to xiaomi_miio domain #29134

merged 11 commits into from Dec 2, 2019


Copy link

raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the services defined in the xiaomi_miio integration by moving the services out of the base domains into the integration domain.


Update the domain and service name for xiaomi_miio services. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for (if applicable): 11330


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
…ces to xiaomi_miio domain

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with a integration (xiaomi_miio) you are listed as a codeowner for? Thanks!

raman325 added 4 commits Nov 27, 2019

This comment has been minimized.

Copy link
Contributor Author

raman325 commented Nov 27, 2019

resolved conflicts, this is due to me changing this file in multiple branches and another PR that came in for this component


This comment has been minimized.

Copy link

rytilahti commented Nov 27, 2019

This is great, thanks for doing the work! In case no one else appears to test these, I'll try to do so over the weekend and get this merged then.

raman325 added 2 commits Nov 28, 2019
@raman325 raman325 mentioned this pull request Nov 28, 2019
2 of 2 tasks complete
raman325 added 2 commits Dec 1, 2019
…325/home-assistant into xiaomi_miio_service_update

* 'xiaomi_miio_service_update' of (41 commits)
  Add fan support to lutron_caseta (#29033)
  Update service domain for alarmdecoder from 'alarm_control_panel' to 'alarmdecoder' (#29127)
  move wemo services to wemo domain (#29135)
  move soundtouch services to soundtouch domain (#29140)
  [ci skip] Translation update
  add services.yaml description for service (#29160)
  Update bluetooth_tracker service name and domain from 'device_tracker' to 'bluetooth_tracker' (#29161)
  Change apns service domain and remove unused variable (#29165)
  Handle case when device can be None (#29171)
  Reduce connection timeout to avoid config flow timeouts (#29172)
  move import to top and add service definition for pilight (#29163)
  Return Jewish Calendar holiday type id support (#29168)
  Use roku.poweron method for media_player.turn_on (#29123)
  Update service domain for ifttt from 'alarm_control_panel' to 'ifttt' (#29129)
  add services.yaml description for matrix service (#29159)
  Update service domain for harmony from 'remote' to 'harmony' (#29146)
  move yamaha service to yamaha domain (#29142)
  Update services.yaml for nuheat (#29133)
  Add opentherm_gw device support (#28722)
  move squeezebox service to squeezebox domain (#29141)

This comment has been minimized.

Copy link
Contributor Author

raman325 commented Dec 2, 2019

@rytilahti please review/test if you haven't already. I made a lot of service changes across a significant number of integrations and this is the only one remaining. I think it would be best to release all of the breaking changes in one release so that users only feel the pain once, and I don't want this one to miss the cutoff.

CC @balloob

balloob approved these changes Dec 2, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 2, 2019
@balloob balloob merged commit 040fd9c into home-assistant:dev Dec 2, 2019
11 checks passed
11 checks passed
CI #20191201.55 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 665613e...7fe0793
codecov/project 94.44% (target 90%)
Dev automation moved this from Reviewer approved to Done Dec 2, 2019
@lock lock bot locked and limited conversation to collaborators Dec 3, 2019
@raman325 raman325 deleted the raman325:xiaomi_miio_service_update branch Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.