Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domain for lifx from 'light' to 'lifx' #29136

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the light.lifx_* services by changing the service calls to be lifx.*.

Description:

Update the domain and service name for lifx.*. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11310

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
raman325 added 2 commits Nov 27, 2019
@amelchio

This comment has been minimized.

Copy link
Contributor

amelchio commented Nov 27, 2019

Sorry to be the grumpy janitor. However, the reason that this change has lingered (at least for LIFX) is that it was supposed to be a slightly larger refactor where service registration is moved to __init__.py, see for example #25753 (comment)

Maybe @balloob changed his mind though, that has happened before ;-)

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Nov 27, 2019

No, we start a long time now to move away from run it on same namespace. I.e. sonos

@pvizeli pvizeli merged commit 1f13809 into home-assistant:dev Nov 27, 2019
12 checks passed
12 checks passed
CI #20191127.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8933540...e1e3b9f
Details
codecov/project 94.5% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@amelchio

This comment has been minimized.

Copy link
Contributor

amelchio commented Nov 27, 2019

That is exactly what I say, this PR does not do it like Sonos.

Same with my linked comment, the Kodi PR first did the simple change of modifying the domain argument but @balloob then argued that the registration should be moved to async_setup in the component.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 27, 2019

I know Paulus has said that the registration should happen in the component module but I think for most platforms where the action happens in the platform that just brings more complexity without any apparent benefit.

I think it's ok to register the service to the integration domain in the platform.

Is there any reason to avoid it?

@raman325 raman325 deleted the raman325:lifx_service_update branch Nov 27, 2019
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Nov 27, 2019

Yeah, I've changed my mind. Let's change the domain first, then try to convince developers to move them to __init__.py

@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.