Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update service domain for lifx from 'light' to 'lifx' #29136
This change breaks existing service call references to the
Update the domain and service name for
Related issue (if applicable): Related to #27289
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Sorry to be the grumpy janitor. However, the reason that this change has lingered (at least for LIFX) is that it was supposed to be a slightly larger refactor where service registration is moved to
Maybe @balloob changed his mind though, that has happened before ;-)
That is exactly what I say, this PR does not do it like Sonos.
Same with my linked comment, the Kodi PR first did the simple change of modifying the domain argument but @balloob then argued that the registration should be moved to
I know Paulus has said that the registration should happen in the component module but I think for most platforms where the action happens in the platform that just brings more complexity without any apparent benefit.
I think it's ok to register the service to the integration domain in the platform.
Is there any reason to avoid it?