Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move nuki service to nuki domain services.yaml and remove missing service #29138

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Description:

Move nuki service to the correct services.yaml

**Related issue (if applicable):**Related to #27289

Pull request with documentation for home-assistant.io (if applicable): N/A

…vice
@raman325 raman325 requested a review from pvizeli as a code owner Nov 27, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
@raman325

This comment has been minimized.

Copy link
Contributor Author

raman325 commented Nov 27, 2019

Just an FYI, this should not be a breaking change because the service already existed in the correct domain, it was just the service definition that was in the wrong spot

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@pvizeli pvizeli merged commit b7896c7 into home-assistant:dev Nov 27, 2019
12 checks passed
12 checks passed
CI #20191127.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8933540...73b211c
Details
codecov/project 94.49% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@raman325 raman325 deleted the raman325:nuki_service_update branch Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.