Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create cloud user if cloud in use #29150

Merged
merged 7 commits into from Nov 28, 2019
Merged

Only create cloud user if cloud in use #29150

merged 7 commits into from Nov 28, 2019

Conversation

@balloob
Copy link
Member

balloob commented Nov 27, 2019

Description:

Only create the cloud system user whenever the user is logged into Home Assistant Cloud.

Depends on new Nabu Casa package 0.30 which should be released once NabuCasa/hass-nabucasa#113 is merged.

Fixes #28083

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@balloob balloob mentioned this pull request Nov 28, 2019
5 of 9 tasks complete
if not self.cloud.is_logged_in:
return

await self.logged_in()

This comment has been minimized.

Copy link
@pvizeli

pvizeli Nov 28, 2019

Member

This is not allow on an interface class design pattern. I restruct the backend library to avoid this construct.

balloob and others added 7 commits Nov 27, 2019
@pvizeli pvizeli force-pushed the cloud-not-create-user branch from ad94559 to 14503b7 Nov 28, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Nov 28, 2019

Rebase to fix gitlab issues

This comment has been minimized.

Copy link
Member

frenck commented Nov 28, 2019 — with Octobox

Retrigger the build should do the trick as well, since GitLab is now back online.

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Nov 28, 2019

@frenck, I removed the gitlab link from pre-commit task

@pvizeli pvizeli merged commit b847d55 into dev Nov 28, 2019
10 of 11 checks passed
10 of 11 checks passed
codecov/patch 76.78% of diff hit (target 94.44%)
Details
CI #20191128.27 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the cloud-not-create-user branch Nov 28, 2019

This comment has been minimized.

Copy link
Member

frenck commented Nov 28, 2019 — with Octobox

Smart!

@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.