Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ios warning for no devices subscribed to ios.notify #29153

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@TomBrien
Copy link
Contributor

TomBrien commented Nov 27, 2019

Description:

Since 2019.1 has launched there is a perfectly reasonable (in fact the standard) case where ios component is loaded (i.e. actionable notifications) but no devices are registed for the now defunct ios.notify service. As such, the log warning relating to this case is no longer relevant. We should just accept no devices enrolled and not start the service.

Related issue (if applicable): home-assistant/home-assistant-iOS#477

Pull request with documentation for home-assistant.io (if applicable): https://github.com/home-assistant/companion.home-assistant covers the iOS app docs and we recently redirected the home-assistant.io docs with home-assistant/home-assistant.io#11298

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
TomBrien added 2 commits Nov 27, 2019
Update upstream
Since 2019.1 has launched there is a perfectly reasonable (in fact the standard) case where ios component is loaded (i.e. actionable notifications) but no devices are registed for the now defunct `ios.notify` service. As such, the log warning relating to this case is no longer relevant.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (ios) you are listed as a codeowner for? Thanks!

@frenck
frenck approved these changes Nov 27, 2019
Copy link
Member

frenck left a comment

Agree, it might become confusing for people migrating as well.

Thanks, @TomBrien! 👍

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@frenck frenck merged commit 8f05388 into home-assistant:dev Nov 27, 2019
12 checks passed
12 checks passed
CI #20191127.62 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.5% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@TomBrien TomBrien deleted the TomBrien:TB-ios-patch branch Nov 27, 2019
@TomBrien TomBrien mentioned this pull request Nov 27, 2019
2 of 2 tasks complete
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.