Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move import to top and add service definition for pilight #29163

Merged
merged 2 commits into from Nov 27, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Description:

Move pilight import outside of initialization method and add service description for send

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): N/A

@cgtobi
cgtobi approved these changes Nov 27, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@cgtobi cgtobi merged commit acc10c2 into home-assistant:dev Nov 27, 2019
11 checks passed
11 checks passed
CI #20191127.96 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing ef21fd2...79b25dd
Details
codecov/project 94.49% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@raman325 raman325 deleted the raman325:pilight_updates branch Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.