Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update demo service domain and service description #29164

Merged
merged 5 commits into from Nov 28, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Breaking Change:

The device_tracker.demo service has been renamed and moved to demo.randomize_device_tracker_data under the demo domain from device_tracker domain.

Description:

Added service description and moved demo to proper domain

Related issue (if applicable): Related to #27289

@raman325 raman325 requested a review from home-assistant/core as a code owner Nov 27, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (demo) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
raman325 added 2 commits Nov 27, 2019
@balloob balloob merged commit 3ecf559 into home-assistant:dev Nov 28, 2019
11 checks passed
11 checks passed
CI #20191128.7 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.5%)
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Needs review to Done Nov 28, 2019
@raman325 raman325 deleted the raman325:demo_service_update branch Nov 28, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 28, 2019

I've updated the breaking change paragraph to mention the service name change.

@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.