Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change apns service domain and remove unused variable #29165

Merged
merged 3 commits into from Nov 27, 2019

Conversation

@raman325
Copy link
Contributor

raman325 commented Nov 27, 2019

Breaking Change:

apns custom service moved from notify domain to apns

Docs: home-assistant/home-assistant.io#11333

Description:

Service domain change as part of HA wide initiative to move services to proper domains

Related issue (if applicable): Related to 27289

…mponent
@balloob balloob merged commit b6d94bc into home-assistant:dev Nov 27, 2019
12 checks passed
12 checks passed
CI #20191127.104 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.5%)
Details
codecov/project 94.43% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Nov 27, 2019
@raman325 raman325 deleted the raman325:apns_service_update branch Nov 27, 2019
@raman325 raman325 mentioned this pull request Nov 28, 2019
2 of 2 tasks complete
@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.