Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Jewish Calendar holiday type id support #29168

merged 2 commits into from Nov 27, 2019


Copy link

tsvi commented Nov 27, 2019

Breaking Change:


In the last breaking change, I merged the holiday description and the holiday type sensor into a holiday sensor with the holiday type, set as the attribute. Apparently some users were using the numerical value of the holiday type which I changed to return the string of the Enum representation.
This adds a third attribute named type_id which returns the numerical value.

Related issue (if applicable): fixes #28825

Pull request with documentation for (if applicable): home-assistant/

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 27, 2019
Dev automation moved this from By Code Owner to Reviewer approved Nov 27, 2019
frenck approved these changes Nov 27, 2019
Copy link

frenck left a comment

Thanks, @tsvi! 👍

@frenck frenck merged commit d7a66e6 into home-assistant:dev Nov 27, 2019
12 checks passed
12 checks passed
CI #20191127.107 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.43%)
codecov/project 94.44% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 27, 2019

This comment has been minimized.

Copy link

quammy commented Nov 27, 2019

Thank you @tsvi and @frenck for a quick treatment and fix!


This comment has been minimized.

Copy link

yuvalabou commented Nov 28, 2019

thank you very much!

@tsvi tsvi deleted the tsvi:jcal_holiday_id branch Nov 28, 2019
@tsvi tsvi restored the tsvi:jcal_holiday_id branch Nov 28, 2019
@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.