Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GoogleConfig initialization into setup of component #29170

merged 1 commit into from Nov 28, 2019


Copy link

elupus commented Nov 27, 2019


Remove helper function that just introduce complexity in setup

Related issue (if applicable): reduces size of #29158


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!


This comment has been minimized.

Copy link
Contributor Author

elupus commented Nov 27, 2019

@MartinHjelmare think you can have a second pair of eyes on this. I'm pretty much maintainer on this integration. but a second pair of eyes doesn't hurt.

@@ -93,7 +93,12 @@ def _check_report_state(data):
async def async_setup(hass: HomeAssistant, yaml_config: Dict[str, Any]):
"""Activate Google Actions component."""
config = yaml_config.get(DOMAIN, {})
google_config = async_register_http(hass, config)
google_config = GoogleConfig(hass, config)

This comment has been minimized.

Copy link

balloob Nov 27, 2019


The reason it was kept separate is so that it's clear which code belongs to the manual set up .

This comment has been minimized.

Copy link

elupus Nov 27, 2019

Author Contributor

but async_setup() won't be run for cloud? so it's still separate. If this is run, there are more problems since they view still got registered with wrong config structure.

Dev automation moved this from Needs review to Reviewer approved Nov 28, 2019
@balloob balloob merged commit 69991bf into home-assistant:dev Nov 28, 2019
12 checks passed
12 checks passed
CI #20191127.108 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing fa1622f...73f831e
codecov/project 94.44% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 28, 2019
@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
@elupus elupus deleted the elupus:google_assistant_init branch Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.