Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NSW Rural Fire Service integration to async library #29181

Merged
merged 9 commits into from Nov 29, 2019

Conversation

@exxamalte
Copy link
Contributor

exxamalte commented Nov 28, 2019

Breaking Change:

Description:

This migrates the NSW Rural Fire Service integration to an async library. Functionality and behaviour is exactly the same as before.

Next steps will be to make this a top-level integration and introduce config flow.

Related issue (if applicable): addresses #27284 as a side-effect

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable):

geo_location:
  - platform: nsw_rural_fire_service_feed

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
exxamalte added 6 commits Nov 14, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 28, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 28, 2019
Copy link
Member

MartinHjelmare left a comment

Looks great!

Dev automation moved this from By Code Owner to Review in progress Nov 29, 2019
exxamalte added 2 commits Nov 29, 2019
Copy link
Member

MartinHjelmare left a comment

Nice!

Dev automation moved this from Review in progress to Reviewer approved Nov 29, 2019
@MartinHjelmare MartinHjelmare merged commit 6126d05 into home-assistant:dev Nov 29, 2019
11 checks passed
11 checks passed
CI #20191129.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 29, 2019
@exxamalte exxamalte deleted the exxamalte:nsw-rfs-aio branch Nov 29, 2019
@lock lock bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.