Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix somfy switch inherit from SwitchDevice instead of ToggleEntity #29182

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@tetienne
Copy link
Contributor

tetienne commented Nov 28, 2019

Description:

See #29057 (review)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Nov 28, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 28, 2019
@tetienne tetienne mentioned this pull request Nov 28, 2019
7 of 7 tasks complete
@MartinHjelmare MartinHjelmare changed the title FIX Inherit from SwitchDevice instead of ToggleEntity Fix somfy switch inherit from SwitchDevice instead of ToggleEntity Nov 28, 2019
Copy link
Member

MartinHjelmare left a comment

Great! Thanks!

Dev automation moved this from By Code Owner to Reviewer approved Nov 28, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 28, 2019

Can be merged when build passes.

@tetienne

This comment has been minimized.

Copy link
Contributor Author

tetienne commented Nov 29, 2019

@MartinHjelmare Anyway to trigger another build? The error is not linked to my code:

unable to access 'https://gitlab.com/pycqa/flake8

@frenck

This comment has been minimized.

Copy link
Member

frenck commented Nov 29, 2019

Retriggered it

@MartinHjelmare MartinHjelmare merged commit 12155cb into home-assistant:dev Nov 29, 2019
12 checks passed
12 checks passed
CI #20191128.24 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 4e107a2...26194cc
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 29, 2019
@lock lock bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.