Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit parallel requests to Philips Hue #29189

Merged
merged 4 commits into from Dec 1, 2019
Merged

Limit parallel requests to Philips Hue #29189

merged 4 commits into from Dec 1, 2019

Conversation

@bramkragten
Copy link
Member

bramkragten commented Nov 28, 2019

Closes #29174
Fixes #29152
Fixes #29087

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 28, 2019

Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration (hue) you are listed as a codeowner for? Thanks!

@tux43

This comment has been minimized.

Copy link

tux43 commented Nov 30, 2019

Has this fix made it into 0.102.3? Also teach me how I can tell?
Thanks for fixing in advance

Dev automation moved this from Needs review to Reviewer approved Nov 30, 2019
Co-Authored-By: Paulus Schoutsen <balloob@gmail.com>
@foxy82

This comment has been minimized.

Copy link
Contributor

foxy82 commented Dec 1, 2019

I've tried this change in my setup as a custom component but the lights still misbehave. E.g. I have a switch which turns on two lights but sometimes only one light comes on. Or they are both meant to come on at the same brightness and they come on at different brightnesses.

@balloob balloob merged commit d91dd68 into dev Dec 1, 2019
10 of 11 checks passed
10 of 11 checks passed
codecov/patch 66.66% of diff hit (target 94.43%)
Details
CI #20191201.48 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the limit-hue-parallel-requests branch Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.