Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support climate.set* for Tado Water Heaters #29191

Merged

Conversation

@springstan
Copy link
Member

springstan commented Nov 28, 2019

Breaking Change:

Description:

  • added support for setting a tado hot water device via climate.set*
  • reference to documentation guide -> Turn on Hot Water

Related issue (if applicable): fixes #29013

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 28, 2019

Hey there @michaelarnauts, mind taking a look at this pull request as its been labeled with a integration (tado) you are listed as a codeowner for? Thanks!

@springstan springstan changed the title Support climate.set* for Tado Hot Water Devices Support climate.set* for Tado Water Heaters Nov 29, 2019
@michaelarnauts

This comment has been minimized.

Copy link
Contributor

michaelarnauts commented Nov 29, 2019

There is already an open PR that fixes this by using the water_heater component. See #27266

Dev automation moved this from Needs review to Reviewer approved Nov 29, 2019
@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Nov 29, 2019

Sorry did not see that one. Should I close this issue then?

@michaelarnauts

This comment has been minimized.

Copy link
Contributor

michaelarnauts commented Nov 29, 2019

This fixes the issue when your heater has temperature control. #27266 also makes it work for heaters without temperature control, but there are still issues with that change, while these changes are working fine.

@michaelarnauts michaelarnauts merged commit 392cdf4 into home-assistant:dev Nov 29, 2019
12 checks passed
12 checks passed
CI #20191128.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 26e674b...241cf78
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 29, 2019
@michaelarnauts michaelarnauts mentioned this pull request Nov 29, 2019
8 of 8 tasks complete
@michaelarnauts

This comment has been minimized.

Copy link
Contributor

michaelarnauts commented Nov 29, 2019

I just noticed that you forgot to add the water heater code to turn it off. I'll add it in a new PR.

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Nov 29, 2019

@michaelarnauts thank you very much! :)

@michaelarnauts michaelarnauts mentioned this pull request Nov 29, 2019
4 of 8 tasks complete
@lock lock bot locked and limited conversation to collaborators Nov 30, 2019
@springstan springstan deleted the springstan:add-hot-water-device-tado branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.