Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle None when trucating long Environment Canada state values #29208

Merged
merged 2 commits into from Nov 29, 2019

Conversation

@michaeldavie
Copy link
Contributor

michaeldavie commented Nov 29, 2019

Description:

Handles states of None when truncating long states, and adds info message.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@project-bot project-bot bot added this to Needs review in Dev Nov 29, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 29, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good.

Please run black code formatter from the project root.

black --fast homeassistant
Dev automation moved this from By Code Owner to Review in progress Nov 29, 2019
@MartinHjelmare MartinHjelmare changed the title Environment Canada - Handle None when trucating long state values Handle None when trucating long Environment Canada state values Nov 29, 2019
Copy link
Member

MartinHjelmare left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Nov 29, 2019
@MartinHjelmare MartinHjelmare merged commit 1322661 into home-assistant:dev Nov 29, 2019
11 checks passed
11 checks passed
CI #20191129.5 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1c824f5...e859bc5
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 29, 2019
@lock lock bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.