Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address DSMR Reader review notes #29209

merged 4 commits into from Nov 30, 2019


Copy link

depl0y commented Nov 29, 2019


Solves some review issues with the original pull request #28701


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 29, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 29, 2019
@MartinHjelmare MartinHjelmare changed the title DSMR Reader Pull Request review notes Address DSMR Reader review notes Nov 29, 2019
Dev automation moved this from By Code Owner to Review in progress Nov 29, 2019
Copy link

MartinHjelmare left a comment


Please also remove the leftover logging import.

homeassistant/components/dsmr_reader/ Outdated Show resolved Hide resolved
depl0y added 2 commits Nov 29, 2019
Copy link

MartinHjelmare left a comment

Looks good! Thanks!

Dev automation moved this from Review in progress to Reviewer approved Nov 30, 2019
@MartinHjelmare MartinHjelmare merged commit bde453b into home-assistant:dev Nov 30, 2019
11 checks passed
11 checks passed
CI #20191130.1 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1322661...5a5cfb1
codecov/project 94.44% (target 90%)
Dev automation moved this from Reviewer approved to Done Nov 30, 2019
@lock lock bot locked and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.