Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Espalexa being detected as Hue Bridge #29237

Merged
merged 1 commit into from Dec 1, 2019
Merged

Fix Espalexa being detected as Hue Bridge #29237

merged 1 commit into from Dec 1, 2019

Conversation

@frenck
Copy link
Member

frenck commented Nov 29, 2019

Description:

ESP firmwares that use the Espalexa library (Like WLED) are discovered by the Hue integration as a bridge using SSDP.

This PR filters Espalexa based devices. Those are filterable by the hardcoded (friendly)name in the library.

https://github.com/Aircoookie/Espalexa/blob/master/src/Espalexa.h#L226

Related issue (if applicable): fixes #29043

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 29, 2019

Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration (hue) you are listed as a codeowner for? Thanks!

@frenck frenck force-pushed the frenck-2019-0274 branch from 3b32527 to 201175c Nov 29, 2019
@balloob
balloob approved these changes Dec 1, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 1, 2019
@balloob balloob merged commit d5efd0b into dev Dec 1, 2019
9 checks passed
9 checks passed
CI #20191129.62 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0274 branch Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.