Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Plex config flow imports where more user input needed #29241

Merged
merged 2 commits into from Dec 1, 2019

Conversation

@jjlawren
Copy link
Contributor

jjlawren commented Nov 30, 2019

Description:

When importing a Plex config from configuration.yaml, additional user input is sometimes required. This can leave a config flow initiated from an import half-completed which is confusing to users. This aborts imports with a warning if they cannot be completed automatically without additional user input.

This also solves an issue reported which makes an already-imported configuration.yaml entry appear to trigger an integration discovery, even when discovery was disabled.

Related issue (if applicable): fixes #27816

Example entry for configuration.yaml (if applicable):

plex:
  token: <SECRET_TOKEN>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 30, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 30, 2019
@balloob
balloob approved these changes Dec 1, 2019
Dev automation moved this from By Code Owner to Reviewer approved Dec 1, 2019
@balloob balloob merged commit 6a02c65 into home-assistant:dev Dec 1, 2019
9 checks passed
9 checks passed
CI #20191130.16 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.