Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to top for seventeentrack #29264

Merged
merged 2 commits into from Dec 1, 2019

Conversation

@springstan
Copy link
Member

springstan commented Nov 30, 2019

Breaking Change:

Description:

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 30, 2019

Hey there @bachya, mind taking a look at this pull request as its been labeled with a integration (seventeentrack) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Dec 1, 2019
@bachya
bachya approved these changes Dec 1, 2019
Copy link
Contributor

bachya left a comment

Thanks!

@bachya

This comment has been minimized.

Copy link
Contributor

bachya commented Dec 1, 2019

Can merge once CI passes.

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Dec 1, 2019

@bachya not really sure why the tests are failing, the credentials seem to be invalid now for some reason. Could you please take a look at it?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 1, 2019

The patch target path needs to be updated to the name imported in the homeassistant module.

with mock.patch("py17track.Client", new=ClientMock):

https://docs.python.org/3/library/unittest.mock.html#where-to-patch

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Dec 1, 2019

@MartinHjelmare thanks a lot for the hint and the link to the documentation!
With that I could update the patch target path successfully so that the tests pass again :)

@bachya bachya merged commit 22225ce into home-assistant:dev Dec 1, 2019
11 checks passed
11 checks passed
CI #20191201.43 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing bde453b...23471f0
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
@springstan springstan deleted the springstan:move-imports-seventeentrack branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.