Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alexa check for "name" channelMetadata attribute #29279

Merged
merged 3 commits into from Dec 3, 2019

Conversation

@Dilbert66
Copy link
Contributor

Dilbert66 commented Dec 1, 2019

Breaking Change:

None

Description:

Add a check for "name" channelMetadata attribute, This attribute will be used as the default channel name to send to the media_player when no channel number is found. This attribute gets filled when the user says Alexa, tune to "<channelname>"

Related issue (if applicable): fixes #29274

`

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 1, 2019

Hey there @home-assistant/cloud, @ochlocracy, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!

@Dilbert66 Dilbert66 changed the title Added check for "name" channelMetada attribute Added check for "name" channelMetadata attribute Dec 1, 2019
@clapbr

This comment has been minimized.

Copy link
Contributor

clapbr commented Dec 1, 2019

@Dilbert66

This comment has been minimized.

Copy link
Contributor Author

Dilbert66 commented Dec 1, 2019

@Dilbert66

This comment has been minimized.

Copy link
Contributor Author

Dilbert66 commented Dec 1, 2019

…hanelMetadata payload section
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Dec 1, 2019

Looks good 👍

@MartinHjelmare MartinHjelmare changed the title Added check for "name" channelMetadata attribute Add alexa check for "name" channelMetadata attribute Dec 1, 2019
…response, returning "name" is not technically valid. Modified to return the value in the callSign field instead since it's a text value. Since there is no returned channel number, cannot return a true numeric value in "channel" field
@balloob balloob merged commit 83b2165 into home-assistant:dev Dec 3, 2019
11 checks passed
11 checks passed
CI #20191201.46 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch No report found to compare against
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Needs review to Done Dec 3, 2019
@Dilbert66 Dilbert66 deleted the Dilbert66:channelcontroller branch Dec 3, 2019
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.