Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve naming and attrs of hostnameless Huawei LTE device tracker entities #29281

Merged

Conversation

@scop
Copy link
Contributor

scop commented Dec 1, 2019

Description:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Dec 1, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 1, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Dec 1, 2019
@MartinHjelmare MartinHjelmare merged commit a9baa24 into home-assistant:dev Dec 1, 2019
12 checks passed
12 checks passed
CI #20191201.20 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5c8a8a6...546f253
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
@scop scop deleted the scop:huawei-lte-device-tracker-macs branch Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.