Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Tibber library #29290

Merged
merged 1 commit into from Dec 1, 2019
Merged

Upgrade Tibber library #29290

merged 1 commit into from Dec 1, 2019

Conversation

@Danielhiversen
Copy link
Member

Danielhiversen commented Dec 1, 2019

Description:

Upgrade Tibber library
https://github.com/Danielhiversen/pyTibber/commits/master

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 1, 2019

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration (tibber) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Dec 1, 2019
@MartinHjelmare MartinHjelmare merged commit 3c9d2b5 into dev Dec 1, 2019
12 checks passed
12 checks passed
CI #20191201.29 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5c8a8a6...c5bb351
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the tibber_lib branch Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.