Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability-attributes #29306

Merged
merged 1 commit into from Dec 2, 2019
Merged

Add capability-attributes #29306

merged 1 commit into from Dec 2, 2019

Conversation

@balloob
Copy link
Member

balloob commented Dec 2, 2019

Description:

Distinguish in entity base classes between attributes that are describe capabilities (min/max mireds for lights) vs describe state (is light on). This allows us to describe the capabilities even when the light is unavailable, which will fix a big annoyance in Google/Alexa, where all lights need to be available before syncing.

This PR only implements it for lights.

Unblocks #28501

CC @elupus

Related issue (if applicable): fixes home-assistant/architecture#297

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob balloob requested a review from home-assistant/core as a code owner Dec 2, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 2, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Dec 2, 2019

Should we label it a breaking change since we change the included light state attributes?

Edit: Nevermind, I see that the capabilities are included in state attributes, so status is the same.

Dev automation moved this from Needs review to Reviewer approved Dec 2, 2019
@elupus
elupus approved these changes Dec 2, 2019
Copy link
Contributor

elupus left a comment

Looks good to me.

@balloob balloob merged commit 9771826 into dev Dec 2, 2019
12 checks passed
12 checks passed
CI #20191202.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the capability-attributes branch Dec 2, 2019
@lock lock bot locked and limited conversation to collaborators Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.