Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WLED white value support for RGBW strips #29312

Merged
merged 1 commit into from Dec 3, 2019
Merged

Improve WLED white value support for RGBW strips #29312

merged 1 commit into from Dec 3, 2019

Conversation

@frenck
Copy link
Member

frenck commented Dec 2, 2019

Description:

This PR implements one of the most requested features I got this month.

The WLED integration used a method to "magically" determine the white value of the RGBW LED strip. This change adds in support for setting a white value when the used LED strip has a white channel.

Related issue (if applicable): n/a

Pull request with documentation for home-assistant.io (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Dec 2, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 2, 2019
Copy link
Contributor

Adminiuga left a comment

LGTM

Dev automation moved this from By Code Owner to Reviewer approved Dec 2, 2019
@balloob balloob merged commit 76aaf8b into dev Dec 3, 2019
12 checks passed
12 checks passed
CI #20191202.17 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0275 branch Dec 3, 2019
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.