Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include telegram_bot message id for all messages #29315

Merged
merged 2 commits into from Dec 3, 2019

Conversation

@luca-angemi
Copy link
Contributor

luca-angemi commented Dec 2, 2019

Description:

Include telegram_bot message id for all messages. This will allow to delete messages sent from user.

Example entry for configuration.yaml (if applicable):

telegram_bot:
  - platform: webhooks
    api_key: !secret telegram_secret
    allowed_chat_ids:
      - !secret telegram_chat_id1
      - !secret telegram_chat_id2

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob
balloob approved these changes Dec 3, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 3, 2019
@fabaff
fabaff approved these changes Dec 3, 2019
@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Dec 3, 2019

Can be merged after the tests are passing.

@springstan

This comment has been minimized.

Copy link
Member

springstan commented Dec 3, 2019

@luca-angemi you can fix the linting error by removing the whitespace in the blank line 756.
To fix the CheckFormat error you can run black --fast homeassistant inside of your development environment.

@balloob balloob merged commit cae802f into home-assistant:dev Dec 3, 2019
11 checks passed
11 checks passed
CI #20191203.14 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b28bc1d...5ac4faa
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.