Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud dependency from mobile_app #29373

Merged
merged 1 commit into from Dec 3, 2019
Merged

Conversation

@balloob
Copy link
Member

balloob commented Dec 3, 2019

Breaking Change:

Loading Mobile App no longer causes Cloud integration to be loaded. If you relied on this, add cloud: to your configuration.yaml.

Description:

Guard all calls into cloud integration from mobile_app.

@MartinHjelmare @pvizeli I guess here too, we could just install after_dependencies and it's not a problem 馃し鈥嶁檪

Related issue (if applicable): Fixes #29347

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 3, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (mobile_app) you are listed as a codeowner for? Thanks!

Copy link
Member

robbiet480 left a comment

LGTM

Dev automation moved this from Needs review to Reviewer approved Dec 3, 2019
Copy link
Member

MartinHjelmare left a comment

What would change if we used after_dependencies?

@balloob

This comment has been minimized.

Copy link
Member Author

balloob commented Dec 3, 2019

This is a similar issue to the OwnTracks <> MQTT one. If we would add cloud to after_dependencies here and we install those requirements as @pvizeli suggested, we wouldn't have to do these checks.

I am starting to lean to that solution btw.

@balloob balloob merged commit e26eebf into dev Dec 3, 2019
12 checks passed
12 checks passed
CI #20191203.59 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 4f8200d...46e2ebe
Details
codecov/project 94.45% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-mobile-app-cloud-dep branch Dec 3, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Dec 4, 2019

add cloud to after_dependencies

I'm fine with that. Other integration can also use cloudhooks and to check all time is cloud loaded or not end up in the issue that we forget a check and it fails. So we would have less complexity and less possible errors.

@lock lock bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can鈥檛 perform that action at this time.