Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative altitude in location updates #29381

Merged
merged 1 commit into from Dec 4, 2019
Merged

Conversation

@balloob
Copy link
Member

balloob commented Dec 4, 2019

Description:

Mobile App did not consider that people could live below sea level 馃檲

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 4, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (mobile_app) you are listed as a codeowner for? Thanks!

@balloob balloob merged commit f6780c1 into dev Dec 4, 2019
12 checks passed
12 checks passed
CI #20191204.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing be316af...e59a8b9
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
@delete-merged-branch delete-merged-branch bot deleted the allow-negative-altitude branch Dec 4, 2019
@lock lock bot locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.