Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to top for egardia #29448

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@springstan
Copy link
Member

springstan commented Dec 4, 2019

Breaking Change:

Description:

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 4, 2019

Hey there @jeroenterheerdt, mind taking a look at this pull request as its been labeled with a integration (egardia) you are listed as a codeowner for? Thanks!

@jeroenterheerdt

This comment has been minimized.

Copy link
Contributor

jeroenterheerdt commented Dec 4, 2019

looks good to me. When I wrote the code this was the required please for imports but maybe things have changed.

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Dec 4, 2019

@jeroenterheerdt Thanks for the review! Yeah things have changed, take a look at the linked issue for more details.

@jeroenterheerdt

This comment has been minimized.

Copy link
Contributor

jeroenterheerdt commented Dec 4, 2019

got it.

@balloob balloob merged commit 85e188d into home-assistant:dev Dec 5, 2019
2 of 6 checks passed
2 of 6 checks passed
CI #20191204.91 failed
Details
CI (Overview CheckFormat) Overview CheckFormat failed
Details
CI (Overview Lint) Overview Lint failed
Details
CI (Overview Validate) Overview Validate failed
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Dec 5, 2019
@lock lock bot locked and limited conversation to collaborators Dec 6, 2019
@springstan springstan deleted the springstan:move-imports-egardia branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.