Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup of Huawei LTE for which we can't get a MAC address #29455

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@scop
Copy link
Contributor

scop commented Dec 4, 2019

Description:

Don't specify None mac as device connection.

Related issue (if applicable): fixes #29188

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Dec 4, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 4, 2019
@balloob balloob merged commit ebc9d17 into home-assistant:dev Dec 5, 2019
2 of 6 checks passed
2 of 6 checks passed
CI #20191204.107 failed
Details
CI (Overview CheckFormat) Overview CheckFormat failed
Details
CI (Overview Lint) Overview Lint failed
Details
CI (Overview Validate) Overview Validate failed
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from By Code Owner to Done Dec 5, 2019
@scop scop deleted the scop:huawei-lte-without-mac branch Dec 5, 2019
@lock lock bot locked and limited conversation to collaborators Dec 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.