Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install requirements of after_dependencies when loading integrations #29491

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@balloob
Copy link
Member

balloob commented Dec 4, 2019

Description:

Install requirements for integrations marked as after_dependencies in the integration manifest. This allows integrations to import from these integrations as normal.

Has come up a couple of times recently. #29373 #29177 - these could now be reverted.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob balloob requested review from andrewsayre, robbiet480 and home-assistant/core as code owners Dec 4, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 4, 2019
@balloob balloob mentioned this pull request Dec 5, 2019
4 of 4 tasks complete
@balloob balloob force-pushed the after-deps branch from a178a4a to 458b0d4 Dec 5, 2019
@balloob balloob force-pushed the after-deps branch from 458b0d4 to 7121abc Dec 5, 2019
@balloob balloob mentioned this pull request Dec 5, 2019
3 of 9 tasks complete
@pvizeli
pvizeli approved these changes Dec 5, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 5, 2019
@pvizeli pvizeli merged commit e99184b into dev Dec 5, 2019
11 checks passed
11 checks passed
CI #20191205.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch No report found to compare against
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the after-deps branch Dec 5, 2019
@lock lock bot locked and limited conversation to collaborators Dec 6, 2019
@balloob balloob added this to the 0.103.1 milestone Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.