Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump georss_generic_client to 0.3 #29532

Merged
merged 2 commits into from Dec 6, 2019
Merged

Conversation

@exxamalte
Copy link
Contributor

exxamalte commented Dec 5, 2019

Breaking Change:

Description:

Bump georss_generic_client to v0.3.
This addresses an issue with RSS feeds that start with a byte order mark which was not handled correctly, and prevented the XML to be parsed.

Related issue (if applicable): fixes #29376

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: geo_rss_events
    name: GDACS
    latitude: -7.7321
    longitude: 111.3823
    radius: 2000
    url: https://www.gdacs.org/xml/rss.xml

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
exxamalte added 2 commits Dec 5, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 5, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 5, 2019
Dev automation moved this from By Code Owner to Reviewer approved Dec 5, 2019
@exxamalte

This comment has been minimized.

Copy link
Contributor Author

exxamalte commented Dec 5, 2019

CI failed to setup the virtual environment :(

@frenck

This comment has been minimized.

Copy link
Member

frenck commented Dec 6, 2019

Gave the CI a little kick in the b. It seems to be resuming now.

@frenck frenck added this to the 0.103.0 milestone Dec 6, 2019
@frenck
frenck approved these changes Dec 6, 2019
@frenck frenck merged commit 33542f0 into home-assistant:dev Dec 6, 2019
12 checks passed
12 checks passed
CI #20191205.98 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 20fdcba...6bb9804
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 6, 2019
@Mariusthvdb

This comment has been minimized.

Copy link
Contributor

Mariusthvdb commented Dec 6, 2019

thx guys, Malte! for the swift response.
Should open a whole new world of feeds.

@exxamalte exxamalte deleted the exxamalte:update-georssevents branch Dec 6, 2019
@lock lock bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.