Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huawei LTE device tracker fixes #29551



Copy link

scop commented Dec 6, 2019


Some fixes to Huawei LTE device tracker.

Related issue (if applicable): fixes #29354


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Dec 6, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 6, 2019
@frenck frenck added this to the 0.103.0 milestone Dec 6, 2019
Dev automation moved this from By Code Owner to Reviewer approved Dec 6, 2019
@MartinHjelmare MartinHjelmare merged commit 31c7198 into home-assistant:dev Dec 6, 2019
12 checks passed
12 checks passed
CI #20191206.26 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 33542f0...cc4b8c8
codecov/project 94.45% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 6, 2019
@scop scop deleted the scop:huawei-lte-device-tracker-fixes branch Dec 7, 2019
@lock lock bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.