Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix neato device info #29570

Merged
merged 1 commit into from Dec 9, 2019
Merged

Conversation

@Santobert
Copy link
Member

Santobert commented Dec 6, 2019

Breaking Change:

Maybe there are some minor changes since we use other sources to fill in device_info. But I can't imagine a use-case that could be broken by this change.

Description:

An endpoint of neao's API broke some time ago. There is a workaround where the error is caught (#29156). Now we use a different endpoint to fetch device information. We are now using get_general_info() instead of get_robot_info() as the last one is intended for debugging purposes.

Please include this in the next release once it has been accepted.

Related issue (if applicable): fixes #29239

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Dec 6, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 6, 2019

Hey there @dshokouhi, mind taking a look at this pull request as its been labeled with a integration (neato) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 6, 2019
@Santobert Santobert changed the title Change source of device_info Fix neato device info Dec 6, 2019
Copy link
Contributor

dshokouhi left a comment

Looks good to me.

Dev automation moved this from By Code Owner to Reviewer approved Dec 7, 2019
@cgtobi
cgtobi approved these changes Dec 7, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

@Santobert Santobert added this to the 0.103.0 milestone Dec 7, 2019
@Santobert

This comment has been minimized.

Copy link
Member Author

Santobert commented Dec 7, 2019

I've tagged this for 0.103.0. Please remove this tag again, if this is not allowed.

@balloob balloob merged commit c399fe2 into home-assistant:dev Dec 9, 2019
12 checks passed
12 checks passed
CI #20191206.61 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 606d310...b77c459
Details
codecov/project 94.45% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 9, 2019
@Santobert Santobert deleted the Santobert:fix_neato_device_info branch Dec 9, 2019
balloob added a commit that referenced this pull request Dec 10, 2019
@lock lock bot locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.