Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional Magic Cube Model to Deconz #29598

Merged
merged 1 commit into from Dec 8, 2019
Merged

Add additional Magic Cube Model to Deconz #29598

merged 1 commit into from Dec 8, 2019

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Dec 7, 2019

Description:

Add additional Magic Cube Model.
My Magic Cube has a different device identifier. The rest of the device functionally seems to be identical.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@SukramJ SukramJ requested a review from Kane610 as a code owner December 7, 2019 20:16
@probot-home-assistant probot-home-assistant bot added integration: deconz small-pr PRs with less than 30 lines. labels Dec 7, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 7, 2019
@probot-home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

Kane610
Kane610 approved these changes Dec 7, 2019
View reviewed changes
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

Dev automation moved this from Needs review to Reviewer approved Dec 7, 2019
@balloob balloob merged commit 7f4baab into home-assistant:dev Dec 8, 2019
Dev automation moved this from Reviewer approved to Done Dec 8, 2019
@SukramJ SukramJ deleted the Deconz-AMQ-Alt branch December 8, 2019 09:13
@lock lock bot locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kane610 Kane610 Kane610 approved these changes

Assignees

@Kane610 Kane610

Labels
cla-signed integration: deconz small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SukramJ @Kane610 @balloob @homeassistant