Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix withings wrong sleep state entry #29651

Merged
merged 4 commits into from Dec 10, 2019
Merged

Fix withings wrong sleep state entry #29651

merged 4 commits into from Dec 10, 2019

Conversation

vangorra
Copy link
Contributor

@vangorra vangorra commented Dec 8, 2019

Breaking Change:

No breaking changes.

Description:

Uses latest sleep state as the withings api appears to no always return a predictable order.

Related issue (if applicable): fixes #29397 fixes #28370

Pull request with documentation for home-assistant.io (if applicable):
N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Dec 8, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 8, 2019
@MartinHjelmare MartinHjelmare changed the title Fixing issue where wrong sleep state entry was being used. Fix withings wrong sleep state entry Dec 8, 2019
@basnijholt basnijholt mentioned this pull request Dec 9, 2019
9 tasks
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can be merged with or without addressing the comment by Bas.

Dev automation moved this from By Code Owner to Reviewer approved Dec 9, 2019
@basnijholt
Copy link
Contributor

If this can get merged, I can rebase #29739 and then isort can be added 👍

@pvizeli pvizeli merged commit 66d2f5f into home-assistant:dev Dec 10, 2019
Dev automation moved this from Reviewer approved to Done Dec 10, 2019
@vangorra vangorra deleted the vangorra_withings_sleep_state_fix branch December 10, 2019 22:57
@lock lock bot locked and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

withings sensor Withings showing wrong values
5 participants