Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Roku to 4.0.0 #29809

merged 1 commit into from Dec 10, 2019

Bump Roku to 4.0.0 #29809

merged 1 commit into from Dec 10, 2019


Copy link

bwarden commented Dec 9, 2019


Bump python-roku dependency to take advantage of new method mentioned in #29123, implemented in jcarbaugh/python-roku#52 and released in version 4.0.0.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@bwarden bwarden force-pushed the bwarden:bump-roku-4.0.0 branch from 01453ce to 093df3f Dec 9, 2019
@MartinHjelmare MartinHjelmare mentioned this pull request Dec 10, 2019
3 of 4 tasks complete
@pvizeli pvizeli merged commit 9049e09 into home-assistant:dev Dec 10, 2019
11 checks passed
11 checks passed
CI #20191209.131 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 38a6fff...093df3f
codecov/project 94.49% (target 90%)
Dev automation moved this from Needs review to Done Dec 10, 2019
@pvizeli pvizeli added this to the 0.103.0 milestone Dec 10, 2019
balloob added a commit that referenced this pull request Dec 10, 2019
@lock lock bot locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.