Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support entity_id: all in lifx.set_state #29919

Merged
merged 1 commit into from Dec 14, 2019
Merged

Conversation

@amelchio
Copy link
Contributor

amelchio commented Dec 13, 2019

Description:

Related issue (if applicable): fixes #29871

Example entry for configuration.yaml (if applicable):

  action:
    service: lifx.set_state
    data:
      entity_id: all
      kelvin: 2700

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@amelchio amelchio added this to the 0.103.1 milestone Dec 13, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 13, 2019
@balloob balloob merged commit 2cb92c6 into home-assistant:dev Dec 14, 2019
12 checks passed
12 checks passed
CI #20191213.49 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a470a72...0265410
Details
codecov/project 94.49% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Dec 14, 2019
@lock lock bot locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.