Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSMR: Fix failure in transform method #30023

Merged
merged 2 commits into from Dec 18, 2019
Merged

DSMR: Fix failure in transform method #30023

merged 2 commits into from Dec 18, 2019

Conversation

@depl0y
Copy link
Contributor

depl0y commented Dec 17, 2019

Description:

Fixes an tranform issue with DSMR Reader integration

Related issue (if applicable): fixes #30022

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Dec 17, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 17, 2019
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Dec 17, 2019

@depl0y to solve the checkformat error you can run black --fast homeassistant inside of your dev environment to format your code with black.

@bachya
bachya approved these changes Dec 18, 2019
Dev automation moved this from By Code Owner to Reviewer approved Dec 18, 2019
@bachya bachya merged commit 36f7096 into home-assistant:dev Dec 18, 2019
7 checks passed
7 checks passed
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Dec 18, 2019
@lock lock bot locked and limited conversation to collaborators Dec 19, 2019
@pvizeli pvizeli added this to the 0.103.3 milestone Dec 20, 2019
@balloob balloob changed the title Fix failure in transform method DSMR: Fix failure in transform method Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.